<div dir="ltr"><div>LGTM, FWIW (I'm really tired today).<br><br><br></div><div>Reviewed-by: Laura Ekstrand <<a href="mailto:laura@jlekstrand.net">laura@jlekstrand.net</a>><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 31, 2015 at 10:26 AM, Fredrik Höglund <span dir="ltr"><<a href="mailto:fredrik@kde.org" target="_blank">fredrik@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This function returns true if the given parameter matches the expected<br>
value, and false otherwise.<br>
<br>
An error message is printed if the parameter value doesn't match the<br>
expected value.<br>
---<br>
 tests/spec/arb_direct_state_access/dsa-utils.c | 17 +++++++++++++++++<br>
 tests/spec/arb_direct_state_access/dsa-utils.h |  7 +++++++<br>
 2 files changed, 24 insertions(+)<br>
<br>
diff --git a/tests/spec/arb_direct_state_access/dsa-utils.c b/tests/spec/arb_direct_state_access/dsa-utils.c<br>
index ec7bb24..f065dbc 100644<br>
--- a/tests/spec/arb_direct_state_access/dsa-utils.c<br>
+++ b/tests/spec/arb_direct_state_access/dsa-utils.c<br>
@@ -77,3 +77,20 @@ dsa_texture_with_unit(GLuint unit)<br>
 {<br>
        glUniform1i(dsa_uniform, unit);<br>
 }<br>
+<br>
+bool<br>
+check_indexed_vao_param_(GLuint vao, GLuint index, GLuint param,<br>
+                         GLuint expected, const char *file, int line)<br>
+{<br>
+       GLuint value;<br>
+       glGetVertexArrayIndexediv(vao, index, param, (GLint *) &value);<br>
+<br>
+       if (value != expected) {<br>
+               fprintf(stderr, "%s[%u] was %u, expected %u (%s:%d)\n",<br>
+                       piglit_get_gl_enum_name(param),<br>
+                       index, value, expected, file, line);<br>
+               return false;<br>
+       }<br>
+<br>
+       return true;<br>
+}<br>
diff --git a/tests/spec/arb_direct_state_access/dsa-utils.h b/tests/spec/arb_direct_state_access/dsa-utils.h<br>
index 7bcf004..707a967 100644<br>
--- a/tests/spec/arb_direct_state_access/dsa-utils.h<br>
+++ b/tests/spec/arb_direct_state_access/dsa-utils.h<br>
@@ -59,6 +59,13 @@ void dsa_init_program(void);<br>
<br>
 void dsa_texture_with_unit(GLuint);<br>
<br>
+bool check_indexed_vao_param_(GLuint vao, GLuint index, GLuint param,<br>
+                              GLuint expected, const char *file, int line);<br>
+<br>
+#define check_indexed_vao_param(vao, index, param, expected) \<br>
+       check_indexed_vao_param_(vao, index, param, expected, \<br>
+                                __FILE__, __LINE__)<br>
+<br>
 #ifdef __cplusplus<br>
 } /* end extern "C" */<br>
 #endif<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.1.4<br>
<br>
_______________________________________________<br>
Piglit mailing list<br>
<a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</font></span></blockquote></div><br></div>