<div dir="ltr">This has been squashed into the test for NamedBufferStorage. </div><div class="gmail_extra"> <div class="gmail_quote">On Wed, Apr 1, 2015 at 4:51 AM, Martin Peres <<a href="mailto:martin.peres@linux.intel.com" target="_blank">martin.peres@linux.intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 23/01/15 21:03, Laura Ekstrand wrote: <div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> --- tests/spec/arb_direct_state_access/namedbufferstorage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_direct_state_access/namedbufferstorage.c b/tests/spec/arb_direct_state_access/namedbufferstorage.c index 2ddfab6..6630467 100644 --- a/tests/spec/arb_direct_state_access/namedbufferstorage.c +++ b/tests/spec/arb_direct_state_access/namedbufferstorage.c @@ -217,8 +217,8 @@ read_subtest(GLboolean coherent, GLboolean client_storage) glClear(GL_COLOR_BUFFER_BIT); glCreateBuffers(1, &srcbuf); + glNamedBufferData(srcbuf, BUF_SIZE, array, GL_STATIC_DRAW); glBindBuffer(GL_COPY_READ_BUFFER, srcbuf); - glBufferData(GL_COPY_READ_BUFFER, BUF_SIZE, array, GL_STATIC_DRAW); /* Copy some data to the mapped buffer and check if the CPU can see it. */ glBindBuffer(GL_COPY_WRITE_BUFFER, buffer); </blockquote> </div></div> While I see the point of having separate commits during the development of the mesa functionality, I fail to see the point of not having this squashed in the second patch. Could you please squash this? _______________________________________________ Piglit mailing list <a href="mailto:Piglit@lists.freedesktop.org" target="_blank">Piglit@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> </blockquote></div> </div>