<html> <head> <meta content="text/html; charset=iso-8859-15" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">Hello; On 04/26/2015 10:47 PM, Arthur Huillet wrote: </div> <blockquote cite="mid:20150426214723.23e1515b@free.fr" type="cite"> <pre wrap="">On Wed, 22 Apr 2015 08:06:51 +0300 Tapani Pälli <a class="moz-txt-link-rfc2396E" href="mailto:tapani.palli@intel.com"><tapani.palli@intel.com></a> wrote: </pre> <blockquote type="cite"> <pre wrap="">All other tests except invalid_enum_check pass on Nvidia binary driver (version 346.35), </pre> </blockquote> <pre wrap=""> What is failing on the NVIDIA binary driver, and can you prove that what Piglit is testing is correct? </pre> </blockquote> It's this part: "The error INVALID_VALUE is generated by NamedFramebufferParameteriEXT and GetNamedFramebufferParameterivEXT if <framebuffer> is not a name returned by GenFramebuffers. <meta http-equiv="content-type" content="text/html; charset=iso-8859-15"> " The subtest 'invalid_enum_check' also checks these 2 cases. <blockquote cite="mid:20150426214723.23e1515b@free.fr" type="cite"> <pre wrap="">I believe quoting the spec in invalid_enum_check would help ensure that all implementations behave the same way. </pre> </blockquote> Yeah, I was lazy here because this spec has such a small errors section. I will add quote from the spec and also rename the function as it tests not only invalid enums but some invalid values too. Thanks; // Tapani </body> </html>