Unfortunately I don't have everything in front of me right now, but I know that Arthur and discussed some of the spec requirements off the mailing list a month or so ago. I had some detailed rationale there that could be added to the tests. Laura <div class="gmail_quote">On Apr 23, 2015 11:11 AM, "Dylan Baker" <<a href="mailto:baker.dylan.c@gmail.com">baker.dylan.c@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">> I think we already ask piglit developers to quote the spec at the > beginning of their tests. I certainly tried to do that on my tests and > only test the behaviour described in this test. If it has been done, > then I guess the review was a problem here. It would seem like multiple > months passed between the moment the patches were written and the moment > they got commited. I fear that no-one wanted to do a good review so it > just got pushed. > Unfortunately this is a huge problem for piglit, I know many of the DSA tests sat on the list for several weeks (6+ IIRC) and were just pushed because no one would review them. Dylan _______________________________________________ Piglit mailing list <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a> </blockquote></div>