<div dir="ltr">Yeah, you mentioned that on IRC... I agree, just haven't gotten around to updating this patch. Probably won't for a week or so.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 7, 2015 at 7:22 AM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It would be nice to keep these tests under names that say they test<br>
out-of-bounds accesses.<br>
<br>
Marek<br>
<div><div class="h5"><br>
On Wed, Jul 29, 2015 at 5:45 PM, Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>> wrote:<br>
> Reading off the end causes out-of-bounds errors on nouveau, and one<br>
> might think that it's somehow barrier-related given the name of these<br>
> tests. If this is a valuable thing to test, there can be a separate test<br>
> for that.<br>
><br>
> Signed-off-by: Ilia Mirkin <<a href="mailto:imirkin@alum.mit.edu">imirkin@alum.mit.edu</a>><br>
> ---<br>
> .../spec/arb_tessellation_shader/execution/barrier-patch.shader_test | 5 ++++-<br>
> tests/spec/arb_tessellation_shader/execution/barrier.shader_test | 5 ++++-<br>
> 2 files changed, 8 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/tests/spec/arb_tessellation_shader/execution/barrier-patch.shader_test b/tests/spec/arb_tessellation_shader/execution/barrier-patch.shader_test<br>
> index d34fdc5..313e9d0 100644<br>
> --- a/tests/spec/arb_tessellation_shader/execution/barrier-patch.shader_test<br>
> +++ b/tests/spec/arb_tessellation_shader/execution/barrier-patch.shader_test<br>
> @@ -12,7 +12,10 @@ patch out int val[6];<br>
> patch out vec4 pcolor;<br>
><br>
> void main() {<br>
> - gl_out[gl_InvocationID].gl_Position = gl_in[gl_InvocationID].gl_Position;<br>
> + if (gl_InvocationID < gl_PatchVerticesIn)<br>
> + gl_out[gl_InvocationID].gl_Position =<br>
> + gl_in[gl_InvocationID].gl_Position;<br>
> +<br>
> if (gl_InvocationID < val.length())<br>
> val[gl_InvocationID] = gl_InvocationID;<br>
><br>
> diff --git a/tests/spec/arb_tessellation_shader/execution/barrier.shader_test b/tests/spec/arb_tessellation_shader/execution/barrier.shader_test<br>
> index 8ac74f0..a505e79 100644<br>
> --- a/tests/spec/arb_tessellation_shader/execution/barrier.shader_test<br>
> +++ b/tests/spec/arb_tessellation_shader/execution/barrier.shader_test<br>
> @@ -12,7 +12,10 @@ out int val[];<br>
> patch out vec4 pcolor;<br>
><br>
> void main() {<br>
> - gl_out[gl_InvocationID].gl_Position = gl_in[gl_InvocationID].gl_Position;<br>
> + if (gl_InvocationID < gl_PatchVerticesIn)<br>
> + gl_out[gl_InvocationID].gl_Position =<br>
> + gl_in[gl_InvocationID].gl_Position;<br>
> +<br>
> if (gl_InvocationID < val.length())<br>
> val[gl_InvocationID] = gl_InvocationID;<br>
><br>
> --<br>
> 2.3.6<br>
><br>
</div></div>> _______________________________________________<br>
> Piglit mailing list<br>
> <a href="mailto:Piglit@lists.freedesktop.org">Piglit@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/piglit" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/piglit</a><br>
</blockquote></div><br></div>