<div dir="ltr">On Fri, Oct 2, 2015 at 2:15 AM, Tapani Pälli <span dir="ltr"><<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>commit 9b445f7a68146f50222a4162b5f7ec68c043e851 changed expected<br>
error value for glBindTextureUnit in bind-texture-unit but did not<br>
change same case in texunits test.<br>
<br>
Signed-off-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>><br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=92215" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=92215</a><br>
---<br>
tests/spec/arb_direct_state_access/texunits.c | 16 ++++++++++++----<br>
1 file changed, 12 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/tests/spec/arb_direct_state_access/texunits.c b/tests/spec/arb_direct_state_access/texunits.c<br>
index ccf7779..f47058c 100644<br>
--- a/tests/spec/arb_direct_state_access/texunits.c<br>
+++ b/tests/spec/arb_direct_state_access/texunits.c<br>
@@ -117,11 +117,19 @@ test_texture_params(void)<br>
<br>
maxUnit = MAX2(MaxTextureCombinedUnits, MaxTextureCoordUnits);<br>
<br>
- /* this should generate an error */<br>
+ /* Section 8.1. of the OpenGL 4.5 Core Profile spec says for<br>
+ * BindTextures:<br>
+ *<br>
+ * "An INVALID_OPERATION error is generated if first + count is<br>
+ * greater than the number of texture image units supported by the<br>
+ * implementation."<br>
+ *<br>
+ * However, it doesn't say the same about BindTextureUnit. Table 2.3<br>
+ * implies that a numeric argument out of range yields INVALID_VALUE,<br>
+ * not INVALID_OPERATION.<br>
+ */<br>
glBindTextureUnit(maxUnit, tex[0]);<br>
- /* INVALID_OPERATION is expected */<br>
- /* (see the GL 4.4 spec for glBindTextures) */<br>
- if (!piglit_check_gl_error(GL_INVALID_OPERATION)) {<br>
+ if (!piglit_check_gl_error(GL_INVALID_VALUE)) {<br>
return false;<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></div></blockquote><div><br></div><div>Looks just like the patch I posted on Wednesday.<br><br></div><div>Reviewed-by: Brian Paul <<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>><br><br> <br></div></div><br></div></div>