<p dir="ltr">Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>></p>
<div class="gmail_quote">On Nov 30, 2015 1:19 PM, "Neil Roberts" <<a href="mailto:neil@linux.intel.com">neil@linux.intel.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">test_once was ignoring the return value of draw_and_test_layer so the<br>
test would report a pass even if it failed.<br>
<br>
Reported-by: Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>><br>
---<br>
<br>
Oops, sorry about that. Thanks for reporting it.<br>
tests/fbo/fbo-depth-array.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/tests/fbo/fbo-depth-array.c b/tests/fbo/fbo-depth-array.c<br>
index b0acd5e..45c8b3b 100644<br>
--- a/tests/fbo/fbo-depth-array.c<br>
+++ b/tests/fbo/fbo-depth-array.c<br>
@@ -446,7 +446,7 @@ test_once(void)<br>
x = 1 + (layer % 3) * (width + 1);<br>
y = 1 + (layer / 3) * (height + 1);<br>
}<br>
- draw_and_test_layer(x, y, layer);<br>
+ pass = draw_and_test_layer(x, y, layer) && pass;<br>
<br>
if (piglit_use_fbo && !test_single_size && layer < layers-1) {<br>
glClearColor(0.2, 0.1, 0.1, 1.0);<br>
--<br>
1.9.3<br>
<br>
</blockquote></div>