<div dir="ltr">I hadn't pushed any changes here, and noticed this was still outstanding while doing some other work. Thanks for doing this work.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 12, 2016 at 2:59 AM, Jose Fonseca <span dir="ltr"><<a href="mailto:jfonseca@vmware.com" target="_blank">jfonseca@vmware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks. I wasn't sure if your changes already had taken care of this. I've pushed it now.<br>
<br>
Jose<br>
<br>
On 12/01/16 00:08, Dylan Baker wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
reviewed-by: Dylan Baker <<a href="mailto:baker.dylan.c@gmail.com" target="_blank">baker.dylan.c@gmail.com</a><br>
<mailto:<a href="mailto:baker.dylan.c@gmail.com" target="_blank">baker.dylan.c@gmail.com</a>>><span class=""><br>
<br>
On Tue, Dec 8, 2015 at 8:14 AM, Jose Fonseca <<a href="mailto:jfonseca@vmware.com" target="_blank">jfonseca@vmware.com</a><br></span><div><div class="h5">
<mailto:<a href="mailto:jfonseca@vmware.com" target="_blank">jfonseca@vmware.com</a>>> wrote:<br>
<br>
Exceptions were not reaching it.<br>
---<br>
framework/results.py | 3 ++-<br>
templates/test_result.mako | 8 ++++++++<br>
2 files changed, 10 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/framework/results.py b/framework/results.py<br>
index eeffcb7..ef19fd4 100644<br>
--- a/framework/results.py<br>
+++ b/framework/results.py<br>
@@ -196,6 +196,7 @@ class TestResult(object):<br>
'subtests': self.subtests,<br>
'time': self.time,<br>
'exception': self.exception,<br>
+ 'traceback': self.traceback,<br>
'dmesg': self.dmesg,<br>
}<br>
return obj<br>
@@ -215,7 +216,7 @@ class TestResult(object):<br>
# pylint: disable=assigning-non-slot<br>
inst = cls()<br>
<br>
- for each in ['returncode', 'command', 'exception',<br>
'environment',<br>
+ for each in ['returncode', 'command', 'exception',<br>
'traceback', 'environment',<br>
'time', 'result', 'dmesg']:<br>
if each in dict_:<br>
setattr(inst, each, dict_[each])<br>
diff --git a/templates/test_result.mako b/templates/test_result.mako<br>
index 229a5a7..ff08797 100644<br>
--- a/templates/test_result.mako<br>
+++ b/templates/test_result.mako<br>
@@ -75,6 +75,14 @@<br>
</pre>${value.command}</pre><br>
</td><br>
</tr><br>
+ % if value.exception:<br>
+ <tr><br>
+ <td>Exception</td><br>
+ <td><br>
+ <pre>${value.exception | h}</pre><br>
+ </td><br>
+ </tr><br>
+ % endif<br>
% if value.traceback:<br>
<tr><br>
<td>Traceback</td><br>
--<br>
2.5.0<br>
<br>
<br>
</div></div></blockquote>
<br>
</blockquote></div><br></div>