[Pixman] fast-scale branch performance improvements

Siarhei Siamashka siarhei.siamashka at gmail.com
Tue Mar 16 03:10:58 PDT 2010


On Monday 15 March 2010, Alexander Larsson wrote:
> On Mon, 2010-03-15 at 03:25 +0200, Siarhei Siamashka wrote:
> > But before it gets committed, some problems with potential fixed point
> > overflows when dealing with large images need to be addressed. I have
> > made a test program which can expose some of these problems:
> > http://cgit.freedesktop.org/~siamashka/pixman/log/?h=largescaling-test
>
> I pushed a new version of my branch, rebased on:
> http://cgit.freedesktop.org/~sandmann/pixman/log/?h=alex-scaler
> on (as before):
> http://cgit.freedesktop.org/~alexl/pixman/log/?h=alex-scaler
>
> This has a new flag FAST_PATH_16BIT_SAFE which handles this problem (and
> it runs your test successfully.

Now it seems to fail scaling-test.

Also gcc shows the following warnings:

pixman-fast-path.c: In 
function ‘fast_composite_scaled_nearest_x888_565_SRC_none’:
pixman-fast-path.c:1560: warning: integer constant is too large for ‘long’ 
type
pixman-fast-path.c:1560: warning: integer constant is too large for ‘long’ 
type
pixman-fast-path.c:1560: warning: integer constant is too large for ‘long’ 
type
pixman-fast-path.c: In 
function ‘fast_composite_scaled_nearest_x888_565_SRC_normal’:
pixman-fast-path.c:1561: warning: integer constant is too large for ‘long’ 
type
pixman-fast-path.c:1561: warning: integer constant is too large for ‘long’ 
type
pixman-fast-path.c:1561: warning: integer constant is too large for ‘long’ 
type

-- 
Best regards,
Siarhei Siamashka


More information about the Pixman mailing list