[Pixman] [PATCH 2/2] Delete simple repeat code
siarhei.siamashka at gmail.com
Wed Nov 3 18:10:38 PDT 2010
On Wednesday 29 September 2010 15:40:33 Søren Sandmann wrote:
> This was supposedly an optimization, but it has pathological cases
> where it definitely isn't. For example it has terrible memory access
> patterns when called with a 1 x n image. With small images in general,
> it will do lots and lots of modulus operations.
> Since no one has ever measure whether it actually is an improvement,
> and since it is doing the repeating at the wrong the stage in the
> pipeline, just delete it.
As it turns out, non-scaled images having NORMAL repeat (tiled pictures) are
actually used occasionally (typically with SRC operator). And removing simple
repeat code caused ~4x performance regression in these cases. Looks like a new
fast path is needed to solve the problem.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: This is a digitally signed message part.
More information about the Pixman