[Pixman] [PATCH] Don't discriminate PAD and REFLECT repeat in standard fast paths

Bill Spitzak spitzak at gmail.com
Tue Sep 21 22:27:14 PDT 2010


On Sep 21, 2010, at 9:04 PM, Siarhei Siamashka wrote:
>
> But now returning back to this issue. Ideally, PAD repeat would be a  
> better
> default instead of NONE. Just because NONE repeat is a bit strange and
> hard to accelerate in hardware. This is one example from  
> freedesktop.org
> bugzilla (and there are more similar reports):
> https://bugs.freedesktop.org/show_bug.cgi?id=27954


Rather than PAD being the default, I think NONE should be changed to  
the equivalent of:

  - intersecting the current clip with a quadrilateral that is equal  
to the bounds of the source surface transformed to the destination
  - draw the image using PAD REPEAT
  - restore the clip to as before.

The result is the black edges of the image are sharp antialiased lines  
no matter what the transform.

This is in fact what users expect, and also what other graphics  
libraries are doing (which explains why the hardware is supporting PAD  
directly).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20100921/e387b101/attachment.html>


More information about the Pixman mailing list