[Pixman] [PATCH] Fixing the runtime error in VS debug build under Windows.

[Gang Ji]

Hi Soeren,

Thanks for looking at this! I am glad that the fix is already in 0.21.6.
 When we build the Debug build of the component with Visual Studio 2008,
obviously, it is smart enough to assert when we assign an uninitialized
variable to itself.  It doesn't happen with Release build though.

Thank you very much!

Best regards,
Gang

On Wed, Mar 30, 2011 at 5:10 AM, Soeren Sandmann <sandmann at cs.au.dk> wrote:

> Hi,
>
> > We have met a run time crash when using a debug VS build under Windows
> due to
> > potential of using an uninitialized variable.  By looking at the code,
> max_vx
> > could also be an uninitialized value.  The fix is to initial that
> variable to
> > 0.  The version we are using is 0.21.4.
>
> Thanks for the patch, but this particular issue is already fixed in git
> master and also in pixman 0.21.6 I believe.
>
> I'm curious how this caused crashes? As far as I can tell, the variable
> is not actually used uninitialized - it was only a compiler warning.
>
>
> Thanks,
> Soren
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pixman/attachments/20110330/6d4a14eb/attachment.htm>