[Pixman] Patch to include xmmintrin.h on Visual C++ in pixman-master

Dimiter 'malkia' Stanev malkia at gmail.com
Thu Mar 15 12:42:49 PDT 2012


I'm compiling with Windows WDK (7.1) which is ~ 2008 compiler. I had to 
replace __inline__ with force_inline:

diff --git a/pixman/pixman-mmx.c b/pixman/pixman-mmx.c
index 9d1f6af..d8cb21f 100644
--- a/pixman/pixman-mmx.c
+++ b/pixman/pixman-mmx.c
@@ -319,7 +319,7 @@ in_over (__m64 src, __m64 srca, __m64 mask, __m64 dest)

  /* Elemental unaligned loads */

-static __inline__ __m64 ldq_u(uint64_t *p)
+static force_inline __m64 ldq_u(uint64_t *p)
  {
  #ifdef USE_X86_MMX
      /* x86's alignment restrictions are very relaxed. */
@@ -338,7 +338,7 @@ static __inline__ __m64 ldq_u(uint64_t *p)
  #endif
  }

-static __inline__ uint32_t ldl_u(const uint32_t *p)
+static force_inline uint32_t ldl_u(const uint32_t *p)
  {
  #ifdef USE_X86_MMX
      /* x86's alignment restrictions are very relaxed. */

On 3/15/2012 12:17 PM, Søren Sandmann wrote:
> Fan Chun-wei<fanc999 at yahoo.com.tw>  writes:
>
>> This is a patch to include xmmintrin.h on Visual C++ in pixman-mmx.c
>> as this is where _mm_shuffle_pi16 and _mm_mulhi_pu16 are defined on
>> that compiler, and the definitions of those functions provided in
>> pixman-mmx.c use gcc-specific items which Visual C++ does not like at
>> all.  This will ensure pixman will compile on Visual C++ when x86-mmx
>> support is enabled.
>
> Looks good to me; pushed to master.
>
> For the other patches to add a build system for MSVC, I am hoping that
> someone with an interest in that compiler will review it. But if not,
> I'll simply verify that it doesn't break on Linux and push it.
>
>
> Thanks,
> Søren
> _______________________________________________
> Pixman mailing list
> Pixman at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pixman


More information about the Pixman mailing list