[Pixman] [PATCH] ARMv6: New fast path implementations that utilise prefetch

[Siarhei Siamashka]

On Tue,  8 Jan 2013 22:22:37 +0000
Ben Avison <bavison at riscosopen.org> wrote:

> This is a revised version of the patch first presented on 2012-12-21.

Thanks. It generally looks ok, but would be definitely easier to review
if split into smaller parts. For example:

1. move of the armv6 scaling fast paths into a separate file
2. SRC fast paths
3. arm_simd_blt/arm_simd_fill
4. OVER fast paths

> Cairo-perf-trace results (before patch)
> 
> [ # ]  backend                  test   min(s) median(s) stddev. count
> [ # ]  image: pixman 0.29.1
> [  0]  image    t-swfdec-giant-steps   20.257   20.291   0.10%    6/6
> [  1]  image     t-firefox-asteroids   13.982   14.006   0.07%    6/6
> [  2]  image      t-firefox-fishbowl   26.032   26.075   0.07%    6/6
> [  3]  image    t-firefox-chalkboard   35.755   35.758   0.02%    5/6
> [  4]  image         t-midori-zoomed    7.449    7.457   0.10%    5/6
> [  5]  image     t-firefox-scrolling   30.675   30.812   0.24%    6/6
> [  6]  image               t-poppler   11.504   11.545   0.23%    6/6
> [  7]  image         t-chromium-tabs    4.762    4.779   0.18%    6/6
> [  8]  image        t-grads-heat-map    3.707    3.723   0.43%    6/6
> [  9]  image  t-firefox-canvas-alpha   19.978   20.279   0.86%    6/6
> [ 10]  image     t-firefox-talos-gfx   29.465   29.535   0.27%    5/6
> [ 11]  image    t-gnome-terminal-vim   20.308   20.354   0.17%    6/6
> [ 12]  image      t-firefox-fishtank   21.396   21.420   0.09%    5/6
> [ 13]  image             t-evolution   12.800   12.898   0.34%    6/6
> [ 14]  image        t-poppler-reseau   21.339   21.853   0.88%    6/6
> [ 15]  image     t-firefox-talos-svg   19.322   19.342   0.07%    6/6
> [ 16]  image  t-firefox-planet-gnome   11.909   11.978   0.27%    6/6
> [ 17]  image     t-firefox-particles   25.155   25.160   0.02%    5/6
> [ 18]  image  t-gnome-system-monitor   26.247   26.259   0.04%    6/6
> [ 19]  image        t-firefox-canvas   17.597   17.645   0.16%    6/6
> [ 20]  image        t-swfdec-youtube    9.870    9.877   0.04%    5/6
> [ 21]  image                  t-gvim   18.557   18.629   0.28%    6/6
> [ 22]  image     t-firefox-paintball   24.541   24.556   0.02%    5/6
> [ 23]  image     t-xfce4-terminal-a1   24.496   24.720   0.46%    6/6
> 
> Cairo-perf-trace results (after patch)
> 
> [ # ]  backend                  test   min(s) median(s) stddev. count
> [ # ]  image: pixman 0.29.1
> [  0]  image    t-swfdec-giant-steps   13.501   13.521   0.10%    6/6
> [  1]  image     t-firefox-asteroids   10.400   10.424   0.12%    5/6
> [  2]  image      t-firefox-fishbowl   22.488   22.490   0.01%    5/6
> [  3]  image    t-firefox-chalkboard   37.193   37.196   0.01%    5/6

The "t-firefox-chalkboard" test seems to have regressed a bit. Is it a
random noise in the measurements? Or one of the optimizations is poorly
performing here?

> [  4]  image         t-midori-zoomed    6.316    6.362   0.31%    6/6
> [  5]  image     t-firefox-scrolling   24.375   24.379   0.01%    4/6
> [  6]  image               t-poppler   11.517   11.544   0.13%    5/6
> [  7]  image         t-chromium-tabs    4.226    4.245   0.26%    6/6
> [  8]  image        t-grads-heat-map    3.727    3.780   0.69%    6/6
> [  9]  image  t-firefox-canvas-alpha   18.897   19.082   0.64%    6/6
> [ 10]  image     t-firefox-talos-gfx   27.889   27.950   0.34%    6/6
> [ 11]  image    t-gnome-terminal-vim   19.411   19.545   0.35%    6/6
> [ 12]  image      t-firefox-fishtank   19.103   19.112   0.12%    6/6
> [ 13]  image             t-evolution   11.303   11.340   0.20%    6/6
> [ 14]  image        t-poppler-reseau   21.678   21.824   0.33%    5/6
> [ 15]  image     t-firefox-talos-svg   18.909   18.933   0.08%    6/6
> [ 16]  image  t-firefox-planet-gnome   10.936   10.966   0.15%    6/6
> [ 17]  image     t-firefox-particles   24.224   24.249   0.07%    6/6
> [ 18]  image  t-gnome-system-monitor   13.538   13.584   0.46%    6/6
> [ 19]  image        t-firefox-canvas   16.394   16.410   0.10%    6/6
> [ 20]  image        t-swfdec-youtube    9.694    9.737   0.31%    6/6
> [ 21]  image                  t-gvim   18.313   18.334   0.12%    6/6
> [ 22]  image     t-firefox-paintball   19.364   19.392   0.07%    6/6
> [ 23]  image     t-xfce4-terminal-a1   22.253   22.409   0.43%    6/6


-- 
Best regards,
Siarhei Siamashka