Hi,<div><br></div><div>I send new patch set of bilinear scaling scanline functions.</div><div><br></div><div><span style="font-family:UnDotum;font-size:medium"><pre style="white-space:pre-wrap">> 1. License/copyright notice header is needed for the newly added file.
> It can be taken from the older NEON assembly file and updated to have
> both Nokia and your (Samsung?) copyright for year 2011.
> 2. Fix indentation problems according to:
> <a href="http://cgit.freedesktop.org/pixman/tree/CODING_STYLE?id=pixman-0.21.6#n22" target="_blank">http://cgit.freedesktop.org/pixman/tree/CODING_STYLE?id=pixman-0.21.6#n22</a>
> 3. More descriptive commit messages would be welcome for patches. And
> commit summaries are better to start with 'ARM: '.
>
> It's a bit regrettable that there are actually no fast paths for solid
> mask and r5g6b5 color format. I think at least 'src_8888_8_0565' could
> work fine and justify the existence of 565 related macros in the code.
>
> And one more nitpick is about this part:
> + mov ip, sp
> + push {r4, r5, r6, r7, r8, r9, r10}
>
> It's usually a good idea to save even number of registers on function
> entry to keep the stack 8 bytes aligned. The 8 bytes alignment is
> required by EABI and is quite critical if you for example call some
> external functions or callbacks from your code or perform 64-bit
> aligned memory accesses with stack. Even though this is not strictly
> needed here, it's safer just in case. On ARM Cortex-A8 this has no
> impact on performance.</pre></span></div><div><br></div><div>I modified my current snapshot based on above siarhei's comment, and made complete new patch set.</div>
<div>Forget about the previous patches.</div><div><br>
</div><div>Following scanline functions are implemented.</div><div><br></div><div>over_8888_8888</div><div>add_8888_8888</div><div>src_8888_8_8888</div><div>src_8888_8_0565</div><div>src_0565_8_x888</div><div>src_0565_8_0565</div>
<div>over_8888_8_8888</div><div>add_8888_8_8888</div><div><br></div><div>I've got success on pixman scaling test.</div><div>Review or comment would be appreciated.</div><div><br></div><div>-- <br>Best Regards,<div>Taekyun Kim</div>
<br>
</div>