<div dir="ltr">On Tue, Dec 22, 2015 at 2:19 PM, Oded Gabbay <span dir="ltr"><<a href="mailto:oded.gabbay@gmail.com" target="_blank">oded.gabbay@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="">On Thu, Jun 4, 2015 at 12:02 PM, Andrea Canciani <<a href="mailto:ranma42@gmail.com">ranma42@gmail.com</a>> wrote:<br>
> The patch does not regress the mingw-based build (basically that used in<br>
> <a href="http://cairographics.org/end_to_end_build_for_win32/" rel="noreferrer" target="_blank">http://cairographics.org/end_to_end_build_for_win32/</a> )<br>
> I did not manage to get the build working on the cmd.exe shell. Do you have<br>
> any instructions (or possibly indications about what is the correct<br>
> environment) for that?<br>
><br>
> AFAICT the change still relies on a Unix-like make command.<br>
> A bigger (but possibly even more interesting) change would be an NMAKE-based<br>
> build, so that the command-line tools available in Visual Studio are<br>
> sufficient for building the whole project.<br>
><br>
> Andrea<br>
><br>
<br>
</span>Hi Andrea,<br>
<br>
I know it has been almost 6 months since you last looked at this<br>
patch, but I would like to ask if you can give it an r-b and then I<br>
will push it to master.<br></blockquote><div><br></div><div>Actually, this is a good time for me to work on pixman, as I have some more free time :)<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If not, what needs to be done to give it an r-b ?<br></blockquote><div> </div><div>The main thing blocking me from an r-b tag originally was that I had been unable to get it working.<br></div><div>I set up an environment to test it and found that it mostly behaves as intended, with the main glitch being that the "clean" target can spit out undesired error logs.<br></div><div><br></div><div>I pushed a branch which is based on Simon's patch here:<br><a href="http://cgit.freedesktop.org/~ranma42/pixman/log/?h=win32-build">http://cgit.freedesktop.org/~ranma42/pixman/log/?h=win32-build</a><br><br>The commits include:<br> - cleanup of the win32 build system (mostly unrelated to the original patch)<br> ea8a070 build: Remove use of BUILT_SOURCES from Makefile.win32<br> 8989759 build: Avoid phony `pixman` target in test/Makefile.win32<br></div><div> - shell-generic compatibility<br> db72f26 build: Do not use `mkdir -p` on Windows<br></div><div> - cmd.exe compatibility<br></div><div> 6223be5 build: Use `del` instead of `rm` on `cmd.exe` shells<br><br></div><div>The last commit is based on the original patch, with some minor differences to avoid path separator handling (instead I changed the current directory) and to avoid error messages from `del` (when it finds no file to delete, it logs a warning that apparently cannot be silenced by any of the flags).<br></div><div><br></div><div>While doing this I discovered that on Win32 fence-image-self-test and cover-test are currently failing (regardless of these patches and apparently also with any combination of MMX, SSE2, SSSE3).<br></div><div>I will try to investigate ASAP.<br><br></div><div>I believe that the first two commits should be "obviously" ok, while the other two are not as trivial.<br>The whole patchset has been tested on Win32, both in an MSYS environment and on cmd.exe (in both cases, using GNU make).<br></div><div><br></div><div>Andrea<br><br></div><div>PS: it looks like pixman has adopted Reviewed-by, Signed-off-by, etc.<br></div><div>I assume that the first three patches should be marked signed off by me, while I am unsure about the tagging for the last patch (I guess it should be credited to Simon).<br><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Unfortunately, I don't have a Windows machine to check this.<br>
<br>
Thanks,<br>
<br>
Oded<br>
<div class=""><div class="h5"><br>
><br>
> On Mon, Jun 1, 2015 at 8:44 AM, Andrea Canciani <<a href="mailto:ranma42@gmail.com">ranma42@gmail.com</a>> wrote:<br>
>><br>
>> The ping was good and the changes make sense. Currently I am replying from<br>
>> the phone and I will not have access to my computer until the 3rd, but I am<br>
>> flagging this mail so that I will test and review the patch asap.<br>
>><br>
>> Sorry for the delay<br>
>> Andrea<br>
>><br>
>> On Jun 1, 2015 8:09 AM, "Siarhei Siamashka" <<a href="mailto:siarhei.siamashka@gmail.com">siarhei.siamashka@gmail.com</a>><br>
>> wrote:<br>
>>><br>
>>> On Wed, 22 Apr 2015 04:01:31 +0200<br>
>>> Simon Richter <<a href="mailto:Simon.Richter@hogyros.de">Simon.Richter@hogyros.de</a>> wrote:<br>
>>><br>
>>> > This finds out whether the standard shell for make is cmd.exe, and<br>
>>> > adjusts<br>
>>> > the build process accordingly.<br>
>>> > ---<br>
>>> > Makefile.win32.common | 14 ++++++++++++--<br>
>>> > 1 file changed, 12 insertions(+), 2 deletions(-)<br>
>>><br>
>>> Thanks for the patch.<br>
>>><br>
>>> But it is a bit difficult for non-Windows folks to see if<br>
>>> it makes any sense or not. So it would be best if some other<br>
>>> Windows user could review and confirm that it works.<br>
>>><br>
>>> I have added Andrea Canciani (the author of the win32 makefiles)<br>
>>> to CC.<br>
>>><br>
>>> > diff --git a/Makefile.win32.common b/Makefile.win32.common<br>
>>> > index 777f94c..335886f 100644<br>
>>> > --- a/Makefile.win32.common<br>
>>> > +++ b/Makefile.win32.common<br>
>>> > @@ -1,5 +1,15 @@<br>
>>> > LIBRARY = pixman-1<br>
>>> ><br>
>>> > +ifeq ($(shell echo ""),)<br>
>>> > +# POSIX style shell<br>
>>> > +mkdir_p = mkdir -p $1<br>
>>> > +rm = $(RM) $1<br>
>>> > +else<br>
>>> > +# DOS/Windows style shell<br>
>>> > +mkdir_p = if not exist $(subst /,\,$1) md $(subst /,\,$1)<br>
>>> > +rm = del $(subst /,\,$1)<br>
>>> > +endif<br>
>>> > +<br>
>>> > CC = cl<br>
>>> > LD = link<br>
>>> > AR = lib<br>
>>> > @@ -47,10 +57,10 @@ endif<br>
>>> ><br>
>>> ><br>
>>> > $(CFG_VAR)/%.obj: %.c $(libpixman_headers)<br>
>>> > - @mkdir -p $(CFG_VAR)<br>
>>> > + @$(call mkdir_p,$(@D))<br>
>>> > @$(CC) -c $(PIXMAN_CFLAGS) -Fo"$@" $<<br>
>>> ><br>
>>> > clean: inform<br>
>>> > - @$(RM) $(CFG_VAR)/*.{exe,ilk,lib,obj,pdb} $(BUILT_SOURCES) ||<br>
>>> > exit 0<br>
>>> > + @-$(call rm,$(CFG_VAR)/*.exe $(CFG_VAR)/*.ilk $(CFG_VAR)/*.lib<br>
>>> > $(CFG_VAR)/*.obj $(CFG_VAR)/*.pdb} $(BUILT_SOURCES))<br>
>>> ><br>
>>> > .PHONY: inform clean<br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Best regards,<br>
>>> Siarhei Siamashka<br>
><br>
><br>
><br>
</div></div><div class=""><div class="h5">> _______________________________________________<br>
> Pixman mailing list<br>
> <a href="mailto:Pixman@lists.freedesktop.org">Pixman@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/pixman" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/pixman</a><br>
><br>
</div></div></blockquote></div><br></div></div>