<div dir="ltr"><div><div><div><div>Yes I will try to send new versions asap.<br><br></div>Known mistakes/problems:<br><br></div>1. I was a bit too fast at deleting the recursion code for the linear filters. The problems were not very visible with the 16-segment simpsons integration, but obvious when reducing to 4 (which otherwise works in most cases). Also it is actually easier to split with my new arguments to the function, so I really should not have done that.<br><br></div>2. x.LINEAR where x is not IMPULSE or BOX or LINEAR is producing artefacts that don't seem to exist in other combinations (or are much less visible in other combinations?). I think I need to investigate this.<br><br></div>3. My comment is somewhat inaccurate and I need to update it. LINEAR.LINEAR is only a cubic at scale==1, it is not possible to replicate what other software calls "cubic" or "bicubic" using this </div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 11, 2016 at 1:16 AM, Oded Gabbay <span dir="ltr"><<a href="mailto:oded.gabbay@gmail.com" target="_blank">oded.gabbay@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Jan 8, 2016 at 8:53 PM, Bill Spitzak <<a href="mailto:spitzak@gmail.com">spitzak@gmail.com</a>> wrote:<br>
><br>
><br>
> On Thu, Jan 7, 2016 at 11:44 PM, Pekka Paalanen <<a href="mailto:ppaalanen@gmail.com">ppaalanen@gmail.com</a>> wrote:<br>
>><br>
>><br>
>> Please keep in mind that the filters GOOD and BEST have been as is for<br>
>> a long long time, AFAIU, so changing their behaviour now is likely not<br>
>> a good idea. They are no longer "a good filter" and "whatever best<br>
>> filter", but "the specific filter called GOOD" and "the specific filter<br>
>> called BEST", in lack of documentation saying otherwise.<br>
><br>
><br>
> Both GOOD and BEST are identical to BILINEAR in the current version of<br>
> Pixman. Therefore anybody relying on the current behaviour can achieve it by<br>
> using BILINEAR. In addition GOOD is unchanged for any scales larger than .75<br>
> or for a scale of exactly .5.<br>
><br>
> Also despite their names, bilinear in no way would be considered "good" or<br>
> "best" by any sane person. We should not add illogical names (like NEW_GOOD<br>
> or whatever) just because of paranoia over back-compatibility. It is also<br>
> highly desirable that the default actually be "good", this cannot be done<br>
> unless GOOD is changed, or the default is changed to "NEW_GOOD".<br>
><br>
> This change was made to Cairo over a year ago with no complaints (except for<br>
> speed issues, which this patch is necessary to solve by moving the fix from<br>
> Cairo to Pixman). Lets get out of the dark ages, and stop doing things that<br>
> are making open source desktops a laughingstock.<br>
><br>
<br>
</div></div>Hi Bill,<br>
I just now read the new emails (I was on PTO for the last week).<br>
It seems you found some mistakes and you want to resend a new version.<br>
Did I understand you correctly ?<br>
If that is indeed the case, then I prefer to wait for that version<br>
(v9), and skip reviewing v8.<br>
Please ack this.<br>
<span class="HOEnZb"><font color="#888888"><br>
Oded<br>
</font></span></blockquote></div><br></div>