[PATCH] Fix Requires.private test

Dan Nicholson dbn.lists at gmail.com
Tue Dec 18 15:18:20 PST 2007


The Requires.private test had incorrect results for Cflags, causing
failures in `make check'. pkg-config always pulls in the Cflags from
Requires.private packages, so we should see -I/private-dep/include.

Thas has been reported multiple times in bugzilla, incuding 9703 and
13530.
---
Dan

 check/check-requires-private |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

=== modified file 'ChangeLog'
--- ChangeLog	2007-06-19 13:58:48 +0000
+++ ChangeLog	2007-12-18 23:03:00 +0000
@@ -1,3 +1,11 @@
+2007-12-18  Dan Nicholson  <dbn.lists at gmail.com>
+
+	* check/check-requires-private: The Requires.private test had
+	incorrect results for Cflags, causing failures in `make check'.
+	pkg-config always pulls in the Cflags from Requires.private
+	packages, so we should see -I/private-dep/include. Thas has been
+	reported multiple times in bugzilla, incuding #9703 and #13530.
+
 2007-06-19  Tollef Fog Heen  <tfheen at err.no>
 
 	* pkg.m4: Fix bug so it's possible to override variables in case

=== modified file 'check/check-requires-private'
--- check/check-requires-private	2005-08-22 10:41:08 +0000
+++ check/check-requires-private	2007-12-18 23:03:00 +0000
@@ -9,14 +9,14 @@
 
 . ${srcdir}/common
 
-# expect cflags from requires-test and public-dep
+# expect cflags from requires-test, private-dep and public-dep
 ARGS="--cflags requires-test"
-RESULT="-I/requires-test/include -I/public-dep/include"
+RESULT="-I/requires-test/include -I/private-dep/include -I/public-dep/include"
 run_test
 
 # still expect those cflags for static linking case
 ARGS="--static --cflags requires-test"
-RESULT="-I/requires-test/include -I/public-dep/include"
+RESULT="-I/requires-test/include -I/private-dep/include -I/public-dep/include"
 run_test
 
 # expect libs for just requires-test and public-dep



More information about the pkg-config mailing list