[PATCH][W32] W32 and MSys compatibility

Dan Nicholson dbn.lists at gmail.com
Fri May 18 09:21:08 PDT 2012


On Sat, Mar 31, 2012 at 09:27:54AM +0400, LRN wrote:
> 
> Apply on top of 0.26
> 
> 06-fix-define-variable-invocation-to-avoid-msys-path-mangling.mingw32.patch:
> Otherwise tests won't pass when running in MSys.

Applied.

> 07-fix-w32-readme.mingw32.patch:
> A simple documentation fix (reflecting the fact that pkg-config is not
> being built against glib-1.2 anymore)

Applied.

> 08-no-need-for-0x0D-we-are-in-text-mode.mingw32.patch:
> stdout is opened in text mode, which means that W32 CRT adds \r
> automatically. Printing it manually produces one extra \r, and
> pkg-config fails to pass some tests because of that.

This was also in a bug and I applied it a week or so ago.

> 09-fix-pkgconfig-pc-path-on.mingw32.patch:
> Can't use deprecated w32 functions with new glib :(
> Also leaks a bit less memory (no that anyone would notice...)

This one is also in bug 45742. I liked your version of the patch better
where a separate symbol was added. However, I like it even more if we
always use the symbol and only use the conditional once when it's
constructed. I also added a version check for glib in configure to make
sure we have a new enough version.

Can you give the attached patch a shot and let me know if it works?

--
Dan


More information about the pkg-config mailing list