On May 19, 2012 10:58 AM, "LRN" <<a href="mailto:lrn1986@gmail.com" target="_blank">lrn1986@gmail.com</a>> wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 19.05.2012 21:13, LRN wrote: > > On 18.05.2012 20:36, Dan Nicholson wrote: > >> On Fri, May 18, 2012 at 09:21:08AM -0700, Dan Nicholson wrote: > >>> On Sat, Mar 31, 2012 at 09:27:54AM +0400, LRN wrote: > >>>> 09-fix-pkgconfig-pc-path-on.mingw32.patch: Can't use > >>>> deprecated w32 functions with new glib :( Also leaks a bit > >>>> less memory (no that anyone would notice...) > >>> > >>> This one is also in bug 45742. I liked your version of the > >>> patch better where a separate symbol was added. However, I like > >>> it even more if we always use the symbol and only use the > >>> conditional once when it's constructed. I also added a version > >>> check for glib in configure to make sure we have a new enough > >>> version. > >>> > >>> Can you give the attached patch a shot and let me know if it > >>> works? > > > >> Whoops, I missed a conditional in pkg.c I wanted to fix. Can you > >> try this patch? > > It compiles (against external glib). And passes all 12 tests. I'll > > install the compiled binaries into my buildslave to see how they > > work > OK, found a silly bug in the patch, here's a patch that fixes your patch. Sheesh, good catch. I'll squash that in and commit soon.Thanks for trying internal glib too. I tried it on a windows VM and hit some problems I didn't feel like investigating. I think libintl is unfortunately required on glib, so I think I'll have to add back GLIB_WITH_NLS at least. What's happening now is the equivalent of --disable-nls since we never define ENABLE_NLS, but clearly there's still code that needs symbols from libintl. I don't think we can get away from that unless we hack around on glib a bit. Can you show the errors you hit? Can you see what happens if you shove GLIB_WITH_NLS back into glib/<a href="http://configure.ac">configure.ac</a>? -- Dan