[PATCH] Provide --help option to display usage of plymouth-set-default-theme
halfline at gmail.com
Sat Dec 5 09:13:45 PST 2009
On Sat, Dec 5, 2009 at 9:19 AM, Adrian Glaubitz
<glaubitz at physik.fu-berlin.de> wrote:
> On Sat, Dec 05, 2009 at 02:45:09PM +0100, Adrian Glaubitz wrote:
>> when running new, unfamiliar commands I usually invoke them with
>> --help to see what options they have. For plymouth-set-default-theme,
>> there is no --help option which I find a bit confusing, especially
>> since the usage is not straight-forward. Since there is a usage
>> function in the script anyway, I wrote a small patch to provide a
>> --help option to display the usage.
>> Moreover, I think, the usage output should be overhauled a bit, but I
>> think that should go into a second patch.
> I have improved the previous patch a bit and now there is an
> additional function "show_help" which displays an extensive help when
> invoking plymouth-set-default-theme with --help. The original function
> usage is still there since it always be called when the script is
> invoked with wrong parameters.
> Please see the attached new patch.
Thanks, this looks good. I've commited this here:
and then made a quick change here:
Have a great weekend,
More information about the plymouth