[PATCH 4/5] add a simple progress sequence helper

[Ray Strode]

Hi,

On Wed, Mar 4, 2009 at 3:22 PM, William Jon McCann
<william.jon.mccann at gmail.com> wrote:
> From: William Jon McCann <jmccann at redhat.com>
>
> This is similar to the progress bar except that it uses a
> sequence of images for the stages of the progress.
Seems fine.  I'd like the existing progress bar to be prettier at some
point (maybe by using images for the end caps and middle part), but
that's something for later.

Minor nits below.  They don't really matter.

> ---
>  src/libplybootsplash/Makefile.am      |    3 +-
>  src/libplybootsplash/ply-progressor.c |  330 +++++++++++++++++++++++++++++++++
>  src/libplybootsplash/ply-progressor.h |   58 ++++++

Not a huge fan of the name.  If the other thing is ply-progress-bar,
maybe this should be ply-progress-animation

> + * Copyright (C) 2008 Red Hat, Inc.
2009!
> +#include <linux/kd.h>
> +
> +#ifndef BAR_HEIGHT
> +#define BAR_HEIGHT 16
> +#endif
copy-and-paste cruft?

Rest seems okay.

--Ray