[PATCH] [main] Write the pid of plymouthd to a file

Ray Strode halfline at gmail.com
Tue Mar 2 11:49:09 PST 2010


Hi,

On Tue, Mar 2, 2010 at 2:42 PM, Scott James Remnant <scott at ubuntu.com> wrote:
> On Tue, 2010-03-02 at 14:20 -0500, Ray Strode wrote:
>
>> > +static char *pid_file = NULL;
>> This should probably go in the state_t structure with the other state.
>>
> I thought that too and actually modified Alberto's patch to do that, but
> then I realised that you don't have a pointed to that in on_crash() -
> it'd mean leaving the pid file around in case of crash.
>
> Which is better?
If you're accessing the variable from on_crash, then keeping it out of
the state struct is better.

--Ray


More information about the plymouth mailing list