[PATCH 2/2] [scripts] Don't hardcode LIBEXECDIR and DATADIR paths

Scott James Remnant scott at ubuntu.com
Tue Mar 2 11:55:44 PST 2010


On Tue, 2010-03-02 at 14:28 -0500, Ray Strode wrote:

> On Tue, Mar 2, 2010 at 1:13 PM, Scott James Remnant <scott at ubuntu.com> wrote:
> > The scripts hard-coded the paths for LIBEXECDIR and DATADIR, unless
> > passed as environment variables.  Instead of doing this, which breaks
> > if plymouth is installed outside of /usr, set these derived from the
> > configure @libexecdir@ and @datadir@ variables just as we do for
> > pkg-config, etc.
> >
> > Since we use so many variables, it makes more sense to generate these
> > scripts from config.status rather than having special Makefile rules
> > for them.
> 
> I guess this is okay. I'm a little uneasy about config.status since it
> doesn't fully expand its arguments.
> 
The other option would be to define those as PLYMOUTH_LIBEXEC_DIR
instead with something like this in configure.ac:

	AS_AC_EXPAND(PLYMOUTH_LIBEXEC_DIR, $libexecdir)

Scott
-- 
Scott James Remnant
scott at ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/plymouth/attachments/20100302/34a34248/attachment.pgp>


More information about the plymouth mailing list