[PATCH 1/2] [script] check that there are pixel displays

Charlie Brej plymouth at brej.org
Thu Mar 11 12:32:35 PST 2010


On 11/03/10 20:25, Scott James Remnant wrote:
> The script plugin only works on pixel displays, however there wasn't
> any check for this, so if a script-based theme was your default
> Plymouth would not fallback to using the text plugin instead.
> ---
>   src/plugins/splash/script/plugin.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/src/plugins/splash/script/plugin.c b/src/plugins/splash/script/plugin.c
> index b35994c..4930677 100644
> --- a/src/plugins/splash/script/plugin.c
> +++ b/src/plugins/splash/script/plugin.c
> @@ -348,6 +348,12 @@ show_splash_screen (ply_boot_splash_plugin_t *plugin,
>   {
>     assert (plugin != NULL);
>
> +  if (ply_list_get_length (plugin->displays) == 0)
> +    {
> +      ply_trace ("no pixel displays");
> +      return false;
> +    }
> +
>     plugin->loop = loop;
>     plugin->mode = mode;
>

Fine by me although I thought the other plugins did it by not attaching 
to any displays and letting the system notice they're not connected. Ray?


More information about the plymouth mailing list