[PATCH 00/21] Improve VT Handling

Scott James Remnant scott at ubuntu.com
Wed Mar 17 22:24:27 PDT 2010


One of the main differences between Ubuntu's use of Plymouth and
Fedora's is that on Ubuntu we've tried to keep the X server on VT7
so that the historical documentation of Ctrl-Alt-F1 giving you a
text console is preserved.

This obviously means that for a smooth transition, Plymouth must also
run on VT7.

We discovered that although Plymouth does have code to attempt to deal
with VTs, none of it is quite right and there are many paths that don't
work unless Plymouth is run on VT1.

This patch set fixes our known problems with the VT handling making it
possible to run Plymouth on any VT of your choosing, with VT1 remaining
the default.

Scott James Remnant (21):
  [terminal] merge console and terminal code
  [terminal] remove references to ply_console_t
  [console] remove console files
  [terminal] replace set_active_vt with activate_vt
  [terminal] add ply_terminal_is_vt() function
  [terminal] only support vt-like operations on VTs
  [terminal] drop support for opening the foreground terminal
  [terminal] don't keep track of active vt, just if vt is active
  [terminal] drop next_active_vt
  [terminal] don't treat ttySx as VT
  [terminal] move terminal opening into renderers/plugins
  [drm] don't run on non-virtual terminals
  [frame-buffer] don't run on non-virtual terminals
  [x11] ignore terminal completely
  [terminal,text,details] move activate vt into plugins
  [drm] default renderer to inactive
  [frame-buffer] default renderer to inactive
  [x11] default renderer to inactive
  [terminal] guard open and close against repeated calls
  [main] add --tty command-line option
  [configure] allow boot and shutdown ttys to be changed

 configure.ac                                 |    7 +
 src/libply-splash-core/Makefile.am           |    2 -
 src/libply-splash-core/ply-boot-splash.c     |   37 +--
 src/libply-splash-core/ply-boot-splash.h     |   10 +-
 src/libply-splash-core/ply-console.c         |  410 --------------------------
 src/libply-splash-core/ply-console.h         |   70 -----
 src/libply-splash-core/ply-renderer-plugin.h |    5 +-
 src/libply-splash-core/ply-renderer.c        |   12 +-
 src/libply-splash-core/ply-renderer.h        |    6 +-
 src/libply-splash-core/ply-terminal.c        |  341 ++++++++++++++++++---
 src/libply-splash-core/ply-terminal.h        |   24 ++
 src/libply-splash-core/ply-text-display.c    |   10 +-
 src/libply-splash-core/ply-text-display.h    |    4 +-
 src/main.c                                   |   61 ++---
 src/plugins/renderers/drm/plugin.c           |   67 +++--
 src/plugins/renderers/frame-buffer/plugin.c  |   62 +++--
 src/plugins/renderers/x11/plugin.c           |   24 +-
 src/plugins/splash/details/plugin.c          |    5 +
 src/plugins/splash/text/plugin.c             |    5 +
 src/tests/ply-boot-splash-test.am            |    2 -
 20 files changed, 469 insertions(+), 695 deletions(-)
 delete mode 100644 src/libply-splash-core/ply-console.c
 delete mode 100644 src/libply-splash-core/ply-console.h



More information about the plymouth mailing list