[PATCH 00/21] Improve VT Handling

Ray Strode halfline at gmail.com
Thu Mar 18 12:21:24 PDT 2010


Hi,

On Thu, Mar 18, 2010 at 1:24 AM, Scott James Remnant <scott at ubuntu.com> wrote:
> One of the main differences between Ubuntu's use of Plymouth and
> Fedora's is that on Ubuntu we've tried to keep the X server on VT7
> so that the historical documentation of Ctrl-Alt-F1 giving you a
> text console is preserved.
>
> This obviously means that for a smooth transition, Plymouth must also
> run on VT7.
>
> We discovered that although Plymouth does have code to attempt to deal
> with VTs, none of it is quite right and there are many paths that don't
> work unless Plymouth is run on VT1.
>
> This patch set fixes our known problems with the VT handling making it
> possible to run Plymouth on any VT of your choosing, with VT1 remaining
> the default.
There are some great patches and fixes here.   I've given it a cursory
look over, and it all looks pretty reasonable.

I'll give it a closer look soon, but I'd like you to go ahead and
commit this stuff to master right away.  We can do any fix ups that
might be necessary once it's landed.

The normal way I land big patchsets like this is:

1) put the changes in a local branch that's rebased to latest master
2) git push origin local-branch-name
3) git merge --no-ff --no-merge local-branch-name
4) git commit with a message like:

[branch-merge] Improve VT Handling

Summary of how all changes come together go here. You could probably
just cut-and-paste your PATCH 00/21 text here.

5) git push origin master

This is a little different than how other projects work, but it has
the nice advantage that it groups the commits as one contained unit in
history with a nice message explaining why they're grouped.

Thanks for doing the legwork on this.

--Ray


More information about the plymouth mailing list