[PATCH] [main] allow clients to watch for <enter> as a keystroke

Charlie Brej plymouth at brej.org
Mon Mar 29 04:06:10 PDT 2010


On 29/03/10 04:56, Steve Langasek wrote:
> "Press<Enter>  to continue" seems like a not uncommon use
> case (we've run into it in the Ubuntu installer), and a natural default
> for "Press any key" is the enter key, so it would be good to permit it here.

Thanks, tested with /n in the keys and general anykey. Committed:
http://cgit.freedesktop.org/plymouth/commit/?id=02ca382344d46fd8f8654588ddcb8e3d25c68e7a

The bigger question is are Backspace and Esc anykeys too. (I would say 
Esc is not Backspace is maybe)

> (The downside is that there's a possible race between a user pressing enter
> and a prompt showing up via ask-for-password and ask-question.  IMHO this is
> a tolerable risk; YMMV.)

A random popup dialogue is an issue with all GUIs and I don't know of 
any solutions so I think that's fine.


More information about the plymouth mailing list