[PATCH] Add "--nowait" option to plymouth

[fykcee1 at gmail.com]

Hi Ray,

Thanks for your comment.
Here comes the second version of the patch, changes since V1:
  1. The option is now an option of subcommands.
  2. The option is renamed to "--ignore-replies".

2011/7/15 Ray Strode <halfline at gmail.com>:
> Hey,
>
>
> On Fri, Jul 15, 2011 at 12:39 AM, fykcee1 at gmail.com <fykcee1 at gmail.com> wrote:
>> The attachment is a patch that adds '--nowait' option to plymouth,
>> which will enable plymouth not to wait for reply of plymouthd.
> seems reasonable enough to me.
>
> Your patch has a little incongruity though.  --wait is a global
> option, but you create a "wait" argument for each request.  If --wait
> is global, it should probably be a separate method on the client
> object, e.g. ply_boot_client_set_wait_for_replies (client...FALSE), or
> an argument to ply_boot_client_new.
>
> I also think something like --quit-before-replies would be better than
I chose a name of "--ignore-replies", just feel "
--quit-before-replies" a little long.



-- 
Regards,
- cee1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-ignore-replies-option-for-some-subcommands.patch
Type: text/x-patch
Size: 57304 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/plymouth/attachments/20110718/ff8d26e3/attachment-0001.bin>