[PATCH] drm: fixed bug regarding minimal buffer size

Dave Airlie airlied at gmail.com
Thu May 10 00:22:27 PDT 2012


On Thu, May 10, 2012 at 6:15 AM, Ray Strode <halfline at gmail.com> wrote:
> Hey,
>
> On Wed, May 9, 2012 at 3:43 PM, Kevin Murphy <kemurphy.cmu at gmail.com> wrote:
>> If we ask for a buffer of size 0 when testing for 32bpp framebuffer
>> support, we trigger a condition in the kernel that will cause the
>> test to fail, ultimately causing a fallback to the framebuffer
>> driver.
>> See http://lxr.free-electrons.com/source/drivers/gpu/drm/ttm/ttm_bo.c#L1193
>> for the block of code that gets triggered.
>
> Oh, bummer.  So ttm drivers report a min_width that's less than they support?
>
>> Compiz ran into a similar
>> issue at some point and they just forced each minimum dimension to 2
>> if it detected it was about to ask for a 0, so that's the approach I
>> took.
> Sounds fine. I think you forgot to attach the patch though?

Yeah a size > 0 is probably a good plan, I'll fix the kernel to not
report 0 as well.

Dave.


More information about the plymouth mailing list