[PATCH] ply-device-manager: Possible null pointer dereference.

Carlos Olmedo Escobar carlos.olmedo.e at gmail.com
Fri Feb 6 08:56:02 PST 2015


Check that udev_device_get_subsystem() return value is not NULL.

Signed-off-by: Carlos Olmedo Escobar <carlos.olmedo.e at gmail.com>
---
 src/libply-splash-core/ply-device-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libply-splash-core/ply-device-manager.c b/src/libply-splash-core/ply-device-manager.c
index 67eba32..753e10d 100644
--- a/src/libply-splash-core/ply-device-manager.c
+++ b/src/libply-splash-core/ply-device-manager.c
@@ -222,7 +222,7 @@ create_seat_for_udev_device (ply_device_manager_t *manager,
                 if (subsystem != NULL && strcmp (subsystem, SUBSYSTEM_DRM) == 0) {
                         ply_trace ("found DRM device %s", device_path);
                         renderer_type = PLY_RENDERER_TYPE_DRM;
-                } else if (strcmp (subsystem, SUBSYSTEM_FRAME_BUFFER) == 0) {
+                } else if (subsystem != NULL && strcmp (subsystem, SUBSYSTEM_FRAME_BUFFER) == 0) {
                         ply_trace ("found frame buffer device %s", device_path);
                         if (!fb_device_has_drm_device (manager, device))
                                 renderer_type = PLY_RENDERER_TYPE_FRAME_BUFFER;
-- 
2.1.4



More information about the plymouth mailing list