And of course that time I missed the Reply All button....<div><br></div><div>Thanks,</div><div>Kevin<span></span><br><br>---------- Forwarded message ----------<br>From: <b>Kevin Murphy</b> <br>Date: Thursday, May 10, 2012<br>
Subject: [PATCH] drm: fixed bug regarding minimal buffer size<br>To: Dave Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>><br><br><br>Ah, I thought I pasted it in.... My mistake. Here it is, for real this time :)<br>
<br>
Thanks,<br>
Kevin<br>
<br>
On Thu, May 10, 2012 at 3:22 AM, Dave Airlie <<a href="javascript:;" onclick="_e(event, 'cvml', 'airlied@gmail.com')">airlied@gmail.com</a>> wrote:<br>
> On Thu, May 10, 2012 at 6:15 AM, Ray Strode <<a href="javascript:;" onclick="_e(event, 'cvml', 'halfline@gmail.com')">halfline@gmail.com</a>> wrote:<br>
>> Hey,<br>
>><br>
>> On Wed, May 9, 2012 at 3:43 PM, Kevin Murphy <<a href="javascript:;" onclick="_e(event, 'cvml', 'kemurphy.cmu@gmail.com')">kemurphy.cmu@gmail.com</a>> wrote:<br>
>>> If we ask for a buffer of size 0 when testing for 32bpp framebuffer<br>
>>> support, we trigger a condition in the kernel that will cause the<br>
>>> test to fail, ultimately causing a fallback to the framebuffer<br>
>>> driver.<br>
>>> See <a href="http://lxr.free-electrons.com/source/drivers/gpu/drm/ttm/ttm_bo.c#L1193" target="_blank">http://lxr.free-electrons.com/source/drivers/gpu/drm/ttm/ttm_bo.c#L1193</a><br>
>>> for the block of code that gets triggered.<br>
>><br>
>> Oh, bummer. So ttm drivers report a min_width that's less than they support?<br>
>><br>
>>> Compiz ran into a similar<br>
>>> issue at some point and they just forced each minimum dimension to 2<br>
>>> if it detected it was about to ask for a 0, so that's the approach I<br>
>>> took.<br>
>> Sounds fine. I think you forgot to attach the patch though?<br>
><br>
> Yeah a size > 0 is probably a good plan, I'll fix the kernel to not<br>
> report 0 as well.<br>
><br>
> Dave.<br>
<br></div>