<div dir="ltr">Charlie, what do you think about this patch?<div class="gmail_extra"> <div class="gmail_quote">On Mon, Apr 15, 2013 at 12:29 AM, Cristian Rodríguez <<a href="mailto:crrodriguez@opensuse.org" target="_blank">crrodriguez@opensuse.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Jeff Mahoney <<a href="mailto:jeffm@suse.com">jeffm@suse.com</a>> Plymouth "zooms" in on smaller displays when multiple displays are used, but the script splash plugin defines the window size as the smallest of the displays. When using a sprite as a background image, the wrong size is used which leaves large chunks of the screen unused. This patch uses the largest display as the window size, which allows it to be appopriately cropped on smaller displays. Signed-off-by: Jeff Mahoney <<a href="mailto:jeffm@suse.com">jeffm@suse.com</a>> Signed-off-by: Cristian Rodríguez <<a href="mailto:crrodriguez@opensuse.org">crrodriguez@opensuse.org</a>> --- src/plugins/splash/script/script-lib-sprite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/splash/script/script-lib-sprite.c b/src/plugins/splash/script/script-lib-sprite.c index e0ced7e..c865cbb 100644 --- a/src/plugins/splash/script/script-lib-sprite.c +++ b/src/plugins/splash/script/script-lib-sprite.c @@ -233,7 +233,7 @@ static script_return_t sprite_window_get_width (script_state_t *state, if (width == 0) width = ply_pixel_display_get_width (display->pixel_display); else - width = MIN (width, ply_pixel_display_get_width (display->pixel_display)); + width = MAX (width, ply_pixel_display_get_width (display->pixel_display)); } return script_return_obj (script_obj_new_number (width)); } @@ -273,7 +273,7 @@ static script_return_t sprite_window_get_height (script_state_t *state, if (height == 0) height = ply_pixel_display_get_height (display->pixel_display); else - height = MIN (height, ply_pixel_display_get_height (display->pixel_display)); + height = MAX (height, ply_pixel_display_get_height (display->pixel_display)); } return script_return_obj (script_obj_new_number (height)); } -- 1.8.1.4 _______________________________________________ plymouth mailing list <a href="mailto:plymouth@lists.freedesktop.org">plymouth@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/plymouth" target="_blank">http://lists.freedesktop.org/mailman/listinfo/plymouth</a> </blockquote></div> </div></div>