<div dir="ltr"><div><div>Hi,<br></div>The use of the smallest screen size is deliberate. If we have multiple screens then the smallest screen is the x=0,y=0 and the default size is it's size. That way, by default, if we place something at the bottom/top of the screen, it will be visible in all screens. This is because sometimes we have screens that are not switched on (large external laptop monitors etc).<br>
<br>Note the larger screens have the top left corner at negative x,y. So you would have to find its position to place the large image.<br><br></div><div>If you would like an image to span the greatest width/height, run through the screen sizes and get the max. Either that or make a new getMaxWidth function.<br>
<br></div><div>Charlie<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 16, 2013 at 1:49 PM, Ray Strode <span dir="ltr"><<a href="mailto:halfline@gmail.com" target="_blank">halfline@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Charlie, what do you think about this patch?<div><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Apr 15, 2013 at 12:29 AM, Cristian Rodríguez <span dir="ltr"><<a href="mailto:crrodriguez@opensuse.org" target="_blank">crrodriguez@opensuse.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Jeff Mahoney <<a href="mailto:jeffm@suse.com" target="_blank">jeffm@suse.com</a>><br>
<br>
Plymouth "zooms" in on smaller displays when multiple displays are used,<br>
but the script splash plugin defines the window size as the smallest<br>
of the displays. When using a sprite as a background image, the wrong<br>
size is used which leaves large chunks of the screen unused.<br>
<br>
This patch uses the largest display as the window size, which allows<br>
it to be appopriately cropped on smaller displays.<br>
<br>
Signed-off-by: Jeff Mahoney <<a href="mailto:jeffm@suse.com" target="_blank">jeffm@suse.com</a>><br>
Signed-off-by: Cristian Rodríguez <<a href="mailto:crrodriguez@opensuse.org" target="_blank">crrodriguez@opensuse.org</a>><br>
---<br>
src/plugins/splash/script/script-lib-sprite.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/plugins/splash/script/script-lib-sprite.c b/src/plugins/splash/script/script-lib-sprite.c<br>
index e0ced7e..c865cbb 100644<br>
--- a/src/plugins/splash/script/script-lib-sprite.c<br>
+++ b/src/plugins/splash/script/script-lib-sprite.c<br>
@@ -233,7 +233,7 @@ static script_return_t sprite_window_get_width (script_state_t *state,<br>
if (width == 0)<br>
width = ply_pixel_display_get_width (display->pixel_display);<br>
else<br>
- width = MIN (width, ply_pixel_display_get_width (display->pixel_display));<br>
+ width = MAX (width, ply_pixel_display_get_width (display->pixel_display));<br>
}<br>
return script_return_obj (script_obj_new_number (width));<br>
}<br>
@@ -273,7 +273,7 @@ static script_return_t sprite_window_get_height (script_state_t *state,<br>
if (height == 0)<br>
height = ply_pixel_display_get_height (display->pixel_display);<br>
else<br>
- height = MIN (height, ply_pixel_display_get_height (display->pixel_display));<br>
+ height = MAX (height, ply_pixel_display_get_height (display->pixel_display));<br>
}<br>
return script_return_obj (script_obj_new_number (height));<br>
}<br>
<span><font color="#888888">--<br>
1.8.1.4<br>
<br>
_______________________________________________<br>
plymouth mailing list<br>
<a href="mailto:plymouth@lists.freedesktop.org" target="_blank">plymouth@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/plymouth" target="_blank">http://lists.freedesktop.org/mailman/listinfo/plymouth</a><br>
</font></span></blockquote></div><br></div></div></div></div>
</blockquote></div><br></div>