[Pm-utils] [patch] fix sourcing of the config files in /etc/pm/config.d/

Tim Dijkstra newsuser at famdijkstra.org
Fri Mar 16 04:21:44 PDT 2007


On Thu, 15 Mar 2007 23:41:24 +0100
Stefan Seyfried <seife at suse.de> wrote:

> On Thu, Mar 15, 2007 at 11:31:10PM +0100, Stefan Seyfried wrote:
> 
> > IMHO this is an important fix, since you cannot configure anything
> > without it.
> 
> BTW (i forgot that):
> - we could of course basically get rid of all those exports below by
>   simply doing:
> 
> +set -a
> >  [ -f /usr/lib/pm-utils/defaults ] && . /usr/lib/pm-utils/defaults
> +set +a
> 
> and then just remove those:
> > +export HIBERNATE_RESUME_POST_VIDEO
> > +export INHIBIT
> > +export PM_LOGFILE
> > +export PM_CMDLINE
> > +export RESUME_MODULES
> > +export SUSPEND_MODULES
> > +export TEMPORARY_CPUFREQ_GOVERNOR
> 
> 
> I would also (again) question the usefulness of requiring the "x" bit to be
> set for the fconfig files, and i would vote for removing the "[ -x $cfg ]"
> check below:

Me too. It is counter intuitive to demand +x on a config file.

grts Tim


More information about the Pm-utils mailing list