[Pm-utils] Video quirks without HAL or dbus

[Matthew Garrett]

On Tue, Nov 04, 2008 at 10:30:45AM -0600, Victor Lowther wrote:

> Did you miss the bits about taking kernel and video driver versions  
> into account? It is not like old, broken software is going away, you  
> know - not with multi year support contracts and all that. Or the bit  
> about new --quirk-none quirks? Adding new quirks to the database that  
> say "kernel rev x with video hardware y running driver z needs no  
> quirks" is less invasive than ripping out quirks that are still needed  
> on older video driver stacks.

No, it's nothing to do with the kernel version. You can't depend on 
that. You need to check the kernel functionality. If KMS is being used, 
you *must* drop all quirks, regardless of the hardware in question. The 
mode hasn't been set through vbe, so you're not going to be able to 
reprogram the same mode as the kernel did. If you try reprogramming a 
mode anyway (which is what the quirks all do) then you've just 
guaranteed that X will fail.

There's no intermediate step here. With the possible exception of the 
s3_bios and s3_mode calls (which are executed before the graphics 
hardware resume code), you must never run any quirks on a KMS setup. 
Even if there are bugs in the KMS code that result in the card not 
resuming properly, running the quirks will not make the situation 
better.

-- 
Matthew Garrett | mjg59 at srcf.ucam.org