[Pm-utils] pm-utils 1.2.1 and 1.1.2.5 released

[Michael Biebl]

2008/10/6 Stefan Seyfried <seife at suse.de>:
> Michael Biebl wrote:
>> 2008/10/4 Victor Lowther <victor.lowther at gmail.com>:
>
>> I also wonder, if we shouldn't  always reset acpi_flags to 0.
>
> IMHO yes, you should. s2ram is doing this for quite some time now after I was
> chasing some strange bug reports. This also gets rid of people still using
> "acpi_sleep=s3_bios,s3_mode" on the kernel command line and then telling you
> "My machine does not need any quirks!!!11!"
>

Cool, so we basically all agree on that in general.

Victor already committed a proposed fix [1].

It uses a different approach then s2ram.

- s2ram *always* set acpi_flags to 0 *before* suspend, unless you pass
custom acpi flags to s2ram

- pm-utils does not set acpi_flags on suspend, unless you pass
--quirk-s3* to pm-suspend. On resume it always sets acpi_flags to 0.
This can have weird effects. If e.g. you use the kernel option
acpi_sleep, acpi_flags would be != 0 on first suspend and 0 on the
second suspend.

But shouldn't we restore the acpi_flags that were set before suspend?

Basically it would be like that

suspend
1.) Store current kernel.acpi_video_flags
2.) Set kernel.acpi_video_flag to 0 unless you pass custom acpi flags to s2ram
resume
3.) restore the value from 1.)

Cheers,
Michael





[1] http://gitweb.freedesktop.org/?p=pm-utils.git;a=commitdiff;h=7fa3f446439de179ae4d4bf73481e785b93fba34;hp=483cefcf0f7a9f3091bd03c7be52085f80134842
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?