<br><br><div class="gmail_quote">On Wed, Feb 3, 2010 at 3:30 PM, Michael Biebl <span dir="ltr"><<a href="mailto:mbiebl@gmail.com">mbiebl@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Hi Victor!<br> <br> 2010/1/15 Michael Biebl <<a href="mailto:mbiebl@gmail.com">mbiebl@gmail.com</a>>:<br> <div class="im">> 2009/12/14 Victor Lowther <<a href="mailto:victor.lowther@gmail.com">victor.lowther@gmail.com</a>>:<br> >> On Thu, 2009-12-10 at 23:16 -0600, Victor Lowther wrote:<br> >>> On Sat, 2009-12-05 at 22:24 -0600, Victor Lowther wrote:<br> >>> > PM-utils 1.3.0-rc1 is not available for testing. Notable changes from<br> >>> > the pm-utils 1.2 series:<br> >>><br> >>> Fresh after -rc1, -rc2 is out. This includes several bugfixes forward<br> >>> ported from the soon-to-be-released pm-utils-1.2.7, along with a new<br> >>> --quirk-test parameter that bypasses the sanity checking imposed by the<br> >>> quirk database handler -- now you too can see what happens when you post<br> >>> your video card in userspace while running a KMS driver!<br> >><br> >> Now at 1.3.0-rc3! What should have been a tiny bugfix in is_set ended<br> >> up breaking everything.<br> ><br> > Here is some feedback/suggestions<br> ><br> > 1.) suspend/hibernate broke for me. I got this in pm-suspend.log<br> > /usr/lib/pm-utils/sleep.d/98-video-quirk-db-handler suspend<br> > suspend:/usr/lib/pm-utils/sleep.d/98-video-quirk-db-handler: line 225:<br> > ((: 0x10de == : syntax error: operand expected (error token is "==<br> > ")<br> > success.<br> ><br> > The result was, that no quirks were applied. I'm having bash 4.1 installed.<br> <br> </div>Thanks to some tireless debugging of Martin Pitt, we were able to<br> track this down and push some important fixes to make it actually work<br> for systems using quirks<br> <br> One issue we noticed is, that the pm-utils quirksdb uses ";" as<br> separator in its match targets.<br> We were wondering, if we shouldn't just use "|" directly.<br> import-fdi-quirkdb makes one suggest that is the intention, but<br> apparently what ends up in the *.quirkdb files is ";"<br> Victor, what's your take on this? See also<br> <a href="http://bugs.freedesktop.org/show_bug.cgi?id=26296" target="_blank">http://bugs.freedesktop.org/show_bug.cgi?id=26296</a><br><div class="im"></div></blockquote><div><br>Yeah, I intended | to be used where an or seperator was required (match this or that). The only time i did not to that was where the data to be matched was purely numeric, but we should use | there as well.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im"> > 2.) Could we please rename 98-video-quirk-db-handler to 98video-quirk-db-handler<br> > for consistencies sake<br> <br> </div>I just went ahead and did that.<br> <div class="im"><br> ><br> > 3.) It would be great, if 98-video-quirk-db-handler was a /bin/sh script.<br> <br> </div>With the advanced features used in there, that is probably not easily<br> possible, so let's skip that for now.<br><div class="im"></div></blockquote><div><br>Oh, it could be done, but right now all the regex matching relies heavily on using bash native regex handling -- in theory egrep would also work without making any modifications to the regexes in the .quirkdb files, but that would involve forking lots of egreps when scanning through the files. <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im"> > 4.) I think we should do a one-time conversion of hal-infos' suspend<br> > quirks and ship that within pm-utils.<br> <br> </div>Aside from that, having an updated pm-quirks tarball based on the<br> latest hal-info git master would be nice.<br></blockquote><div><br>I was planning on making it a separate tarball.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Victor, do you have time to roll a new, up-to-date of pm-quirks (maybe<br> including that in pm-utils directly)<br> and also a 1.3.0-rc4 with the fixes that have been committed.<br></blockquote><div><br>Sure. I apologize for not having done so sooner, but 10 hour days and sleep-averse toddlers do not make for the best conditions to code in.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> Thanks,<br> <div><div></div><div class="h5">Michael<br> <br> <br> <br> --<br> Why is it that all of the instruments seeking intelligent life in the<br> universe are pointed away from Earth?<br> </div></div></blockquote></div><br>