[Poppler-bugs] [Bug 13338] Making pdftops preserve PDF page labels

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=13338





------- Comment #2 from tsdgeos at terra.es  2007-11-22 11:16 PST -------
Are you the coder of the patch?

I particulary dislike the 

    default:
      if (c < 0x20 || c > 0x7e) {
    case '(':
    case ')':
        writePSFmt("\\{0:03o}", c);
        j += 4;
        break;
      } else {
       writePSChar(c);
       ++j;
      }

construct, having a case in middle of the if makes my cry, besides, that's not
what the former code does, this always outputs 
writePSFmt("\\{0:03o}", c);
when finding a ( while the original one only does on first character.

Also from what i understand

    // Omit parentheses if the string is comprised of one or more
    // alphanumeric characters.

is actually

    // Omit parentheses if the string is comprised of one or more
    // non alphanumeric characters.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.