[Poppler-bugs] [Bug 19218] Poppler should not give compile time warnings

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=19218





--- Comment #16 from Hib Eris <hib at hiberis.nl>  2008-12-22 09:04:41 PST ---
(In reply to comment #13)
> Most of your patch 3 is wrong, see how
> 
> int nObjects = INT_MAX;
> if (nObjects*(int)sizeof(int)/sizeof(int) != nObjects)
>     printf("UEEEEEEE\n");
> 
> Warns you that you are about to overflow, but
> 
> int nObjects = INT_MAX;
> if (nObjects*(int)sizeof(int)/(int)sizeof(int) != nObjects)
>     printf("UEEEEEEE\n");
> 
> does not
> 

I see... the code did not really make sense to me, now I understand it a little
more. I will provide a new patch, please tell me if it is any better.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.