[Poppler-bugs] [Bug 14012] New: Two "use after free" bugs in HtmlOutputDev.cc

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=14012

           Summary: Two "use after free" bugs in HtmlOutputDev.cc
           Product: poppler
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: kmaraas at gnome.org


The coverity checker found these two:

--- a/utils/HtmlOutputDev.cc
+++ b/utils/HtmlOutputDev.cc
@@ -820,8 +820,8 @@ void HtmlOutputDev::doFrame(int firstPage){
   fName->append(".html");

   if (!(fContentsFrame = fopen(fName->getCString(), "w"))){
-    delete fName;
     error(-1, "Couldn't open html file '%s'", fName->getCString());
+    delete fName;
     return;
   }

@@ -934,8 +934,8 @@ HtmlOutputDev::HtmlOutputDev(char *fileName, char *title,
       if (!xml) right->append(".html");
       if (xml) right->append(".xml");
       if (!(page=fopen(right->getCString(),"w"))){
-       delete right;
        error(-1, "Couldn't open html file '%s'", right->getCString());
+       delete right;
        return;
       }  
       delete right;


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.