[Poppler-bugs] [Bug 19670] Colorizing text in pattern colorspace solved
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Sat Jan 31 16:45:53 PST 2009
http://bugs.freedesktop.org/show_bug.cgi?id=19670
--- Comment #12 from Albert Astals Cid <tsdgeos at terra.es> 2009-01-31 16:45:53 PST ---
Some quick comments (i've not had a look at what you are doing, just a bit at
general things):
* Thanks again for the code
* With patches it's much easier to review :-)
* I see you seem to work in a publish company or something similar, are you
aware of the licensing of poppler and what it means and are you sure you can
contribute the code under that license?
* patch from comment #4 looks ok
* patch from comment #4 memsetting looks like a workaround for a problem
somewhere else in the code, have you tried removing the code and passing the
program though valgrind with the problematic pdf to see if it reports anything?
* patch from comment #4 if you don't use the code at the moment i'll prefer
leaving it out
* patch from comment #5 is the same than patch from comment #4
* In patch from comment #8 I'd say that in Gfx::opEndText you are missing a
delete colorSpaceText;
before
colorSpaceText = NULL;
* In patch from comment #8: we don't use exceptions in poppler so that code
has to be removed/reworked
* In patch from comment #9 I guess there's a
void PSOutputDev::beginTextObject(GfxState *state);
missing in PSOutputDev.h
* What is CIOutputDev for?
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the Poppler-bugs
mailing list