[Poppler-bugs] [Bug 23030] patch to disable font substitution in pdftops

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23030





--- Comment #6 from William Bader <williambader at hotmail.com>  2009-07-30 14:59:12 PST ---
> The patch doesn't seem much clean to me, for example the value of xs is
> calculated using psSubstFonts[i].mWidth that is not really "right" since you
> are not substituting the font.

I tried to make the smallest possible change.  The value of i is still a valid
index.  When not substituting, I let it continue to calculate everything as
before, but then at the end, I set xs = 1.  If you want me change the entire
sequence to
if (substFonts) {
  calculate w1, w2, and xs as before
} else {
  xs = 1;
}
I can make a new set of patches.

> Also i don't see why you need GBool substFonts; in PSOutputDev.h if the variable is just used in a function

I followed the examples of the other command line parameters.  I think that the
variable must be stored in PSOutputDev.h so that PSOutputDev.cc does not need
to know the internals of pdftops.cc.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.