[Poppler-bugs] [Bug 27482] Colorizing text and masks in pattern colorspace

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27482

--- Comment #6 from Carlos Garcia Campos <carlosgc at gnome.org> 2010-04-09 02:38:27 PDT ---
(In reply to comment #5)
> (In reply to comment #4)
> 

> To hide the restoreState from Gfx.cc and do it i.e. in the output device (keep
> in mind that we stll need the text clipping path) in´the endTextObject in the
> output device, we would need the doPatternFill available in endTextObject. This
> would make it clearer, but would need much more changes in code. And please
> keep in mind, that this behaviour (calling out->restoreState without matching
> out->saveState in Gfx.cc but with matching saveState in
> SplashOutputDev::beginTextObject,

what I look confusing is that endTextObject already calls restoreState(). 

>  I don't mean that this makes it more
> understandable, but at least it seems to work) was already introduced in the
> patch of bug 19670, this patch just complete that behaviour where it is
> missing.

I know, but I didn't see your patches at that time, we should probably discuss
this in the original bug report, but it's closed now so better use this one
which is mostly the same topic and it's open :-)

> Regarding cairo output: I never compiled it and therefore never tested it
> 'cause I have no test case for it, but in my opinion simply drawing the image
> mask will loose the black shadow of the white text in
> http://www.alfa.de/2285316_1_4.pdf (because the image mask will just paint
> white color, the black shadow comes from the pattern colorspace), and it should
> give incredibal results with
> http://www.alfa.de/de/admin/content/document/PDF/cafebarspielsalon_26022009_01.pdf
> from bug 19994 where I introduced colorizing image masks with pattern
> colorspace.

I'll try with those to fix cairo output device if it's broken, thanks!

> Hoply this comments make the things clearer.

Yes, sure, thank you very much.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.