[Poppler-bugs] [Bug 27482] Colorizing text and masks in pattern colorspace

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27482

--- Comment #9 from thomasf <Thomas.Freitag at alfa.de> 2010-04-16 10:18:15 PDT ---
(In reply to comment #8)
> I cannot reproduce any uninitialized memory access without the Function.cc
> patch, moreover you are looping over "c" but not using it at all. Can you
> please provide some backtrace or more info explaining how that happens?

You're true, I cannot reproduce it either. I don't know, if it comes from other
code changes, that it is no more reproducable, and okay, the correct code would
be

Function::Function() {
    int c;
    for (c = 0; c < funcMaxInputs; c++) {
        domain[c][0] = 0.0;
        domain[c][1] = 1.0;
        range[c][0] = 0.0;
        range[c][1] = 1.0;
    }
}

And even if I think that it is a good idea to initialize all class variable in
a constructor and don't let it up to the compiler to do it correctly, it's up
to You if You commit this part of code or not.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.