[Poppler-bugs] [Bug 28780] Add getLabel method to FormWidget

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28780

Mark Riedesel <mark at klowner.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37162|0                           |1
        is obsolete|                            |

--- Comment #5 from Mark Riedesel <mark at klowner.com> 2010-07-31 11:36:17 PDT ---
Created an attachment (id=37487)
 View: https://bugs.freedesktop.org/attachment.cgi?id=37487
 Review: https://bugs.freedesktop.org/review?bug=28780&attachment=37487

FormField name patch

Thanks for the input Albert.

You are indeed correct that calling delete on a null value is safe, I was just
following the code convention in the rest of the source. The new patch doesn't
have the non-null checks.

You are also correct regarding the strange indentation. It looks like I
introduced some indentation problems while moving the changes around for the
patch. That should now be fixed.

The issue regarding UTF16 and ASCII T fields in a document is also valid,
although I haven't seen any PDFs (yet, at least) that have mixed encodings in
the T fields. One solution would be to convert everything to UTF16 (using
pdfDocEncodingToUTF16 perhaps?), but it seems to me as though that might
introduce problems.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.