[Poppler-bugs] [Bug 7107] Windows portability fixes

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=7107





--- Comment #11 from Patrick Spendrin <ps_ml at gmx.de>  2010-03-24 14:50:36 PST ---
(In reply to comment #10)
> (In reply to comment #8)
> > 1) in goo/gfile.cc _MAX_PATH probably can be defined to MAX_PATH (which is
> > defined on mingw)
> 
> In goo/gfile.cc I see a limits.h included only on !_WIN32; do both MSVC and
> mingw provide it? Also, does it provide such _MAX_PATH, or should it be changed
> to the "classic" PATH_MAX?
Hm, after some more investigation I found this: both mingw and msvc contain
_MAX_PATH in stdlib.h - and after removing -ansi, this is fixed for mingw too
(__STRICT_ANSI__ is around _MAX_PATH)
> 
> > 2) in poppler/Annot.cc strdup is used which seems to be a non-ansi extension
> > according to mingw. This means that the -ansi keyword would need to be removed
> > or a replacement be found (also _strdup is not defined).
> 
> Hm ok, I'll move it to a Linux-only section.
thanks, this error got fixed.
> 
> > 3) in poppler/GlobalParamsWin.cc was an error about settings _WIN32_IE to at
> > least 0x0500, so I did that. This fix is the only one that could be committed
> > directly.
> 
> Fixed locally.
> 
got fixed as well.

Ok, One more thing to complain about:
could you rename the folder test within the poppler main source directory to
tests? This way it won't collide with the test target added by ctest on msvc.
Until now, nmake test will tell you that test target is already up to date (the
folder).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.