[Poppler-bugs] [Bug 39385] pdftohtml: add image and font extraction

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39385

--- Comment #4 from Albert Astals Cid <tsdgeos at terra.es> 2011-08-18 12:02:59 PDT ---
Some comments:
 * Please attach only one set of consecutive patches, having two sets of
patches that have "conflicting" order (e.g. there is a patch with number 10 in
both tars) is difficult to follow
 * Please rebase the patches against master since the first set of patches
include parts of the text rotation feature and other patches that are already
commited to master
 * Please squash commits 0007-created-SplashOutputDevHtmlImages-class.patch,
0008-Fixed-spacing-line-length-issues.patch and
0009-Moved-SplashOutputDevHtmlImages-into-the-utils-direc.patch since there is
no need for us to see you moved the code around
 * Please remove the .gitignore and README.contributors and similar changes
from 0009, they have nothing to do with this feature, we might or might not
want them but cramming everything into a single bugreport makes it almost
impossible to review in a timely fashion
 * 0010-Add-background-color-to-main-div-so-it-doesn-t-rely-.patch Seems like a
non related feature and i'd prefer it to be sent separately, and giving the
user the option to set the background color (i can easily imagine situations
where the background color is not white)
 * Please do not break the encoding of the files, e.g.
-// Copyright (C) 2010 Christian Feuersänger <cfeuersaenger at googlemail.com>
+// Copyright (C) 2010 Christian Feuersï¿œnger <cfeuersaenger at googlemail.com>
is not good
 * Please also squash unneded commits like
0015-Modified-Splash.cc-to-store-coordinates-of-most-rece.patch that you seem
to revert in 0019-Images-now-spliced-out-of-splashed-and-output-to-fil.patch it
is not fun to review a patch just to discover the code just disappears in the
next commit
 * 0039-Speed-up-the-extraction-of-images-by-40.patch includes adding a debug
option to GlobalParams, that is unwanted and has nothing to do with the
definition of the patch "Subject: [PATCH 39/52] Speed up the extraction of
images by 40%"
 * 0043-Clean-up-debug-output.-Remove-a-few-compiler-warning.patch contains a
fetch-user-archives.pl that is unwanted and again has nothing to do with the
definition of the patch "[PATCH 43/52] Clean up debug output.  Remove a few
compiler warnings."

Please fix these issues and i'll have a look once you provide an new set of
patches.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.