[Poppler-bugs] [Bug 33401] Page index calculation from pagelabel fails on multiple pagelabel prefixes

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33401

--- Comment #4 from kellner at kit.edu 2011-01-25 01:54:24 PST ---
Created an attachment (id=42439)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42439
 Review: https://bugs.freedesktop.org/review?bug=33401&attachment=42439

updated proposed patch

I don't think that my patch will "break" any standard-conformant
pdf file.

Page label infos are stored as a list of labeling ranges.  A label
is in a labeling rage iff the prefixes match and the number portion
of the label is in the labeling range.  If a label is not in a
labeling range, that range should be treated in the same manner.

While looking at the code, I found an even better fix:  The current
code computes the local variable base from interval->length.  But
interval->length is itself computed from interval->base.  We do not
have to keep track of the current base because it is already stored
in interval->base.

The updated proposed patch actually results in less code.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.