[Poppler-bugs] [Bug 39426] New: Object::dictLookup() not C++ conforming in libpoppler-dev

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39426

           Summary: Object::dictLookup() not C++ conforming in
                    libpoppler-dev
           Product: poppler
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: general
        AssignedTo: poppler-bugs at lists.freedesktop.org
        ReportedBy: rpkrawczyk at gmail.com


In libpoppler-dev there is a minor problem. The function declaration of
Object::dictLookup and Object::dictLookupNF ist

In libpoppler-dev:
Package: libpoppler-dev
Architecture: amd64
Source: poppler
in Ubuntu release: Description: Ubuntu 11.04, Release: 11.04
is a minor coding style bug. The function declaration("Object.h", line 216):

  Object *dictLookup(char *key, Object *obj, std::set<int> *fetchOriginatorNums
= NULL);
  Object *dictLookupNF(char *key, Object *obj);

is not conforming to C++ standards. The first argument key is constant, so if
providing a constant string via "somestring" one gets a compile time warning.
The same is true for ("Dict.h", line 75):

  Object *lookup(char *key, Object *obj, std::set<int> *fetchOriginatorNums =
NULL);
  Object *lookupNF(char *key, Object *obj);

Later on in the code it is correctly a "const char *". Please fix to get rid of
this annoying warning.

Do you need anything else?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.